refactor(api): Evaluators #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/less_complex_parse
branch
from
7bf34de
to
78ae61b
Compare
|
Named funcs, much clearer. Why though use a string and a switch? You could just pass in the function itself. The callers wouldn't notice the change from string to func, no? |
sh0rez
requested changes
Nov 27, 2020
|
@Duologic it is not documented at the moment, but I usually refer to |
Duologic
changed the title
Duologic
force-pushed
the
duologic/less_complex_parse
branch
from
5b94006
to
f75b153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With inline environments, I introduced quite a bit of complexity to the code base. This is a first attempt at trying to
reduce the complexity.
I've observed this pattern in https://github.com/grafana/cortex-tools/blob/master/pkg/rules/parser.go#L27-L37