feat: multiple inline environments #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `Loader.List(path, opts)` which returns all environments that could possibly be found at path. This can be used to prompt the user for the correct inline environment, while the actual Load does not need to be concerned with this
Duologic
force-pushed
the
duologic/multi_env
branch
from
cb7c569
to
f76db89
Compare
sh0rez
requested changes
Jan 9, 2021
sh0rez
requested changes
Jan 9, 2021
This reverts commit e6dd7e7.
sh0rez
approved these changes
Jan 10, 2021
|
Thanks for the patience and review efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a solution to work with multiple inline environments. Bulk operations like
tk export --recursiveandtk env listwill now be able to work on multiple inline environments found in amain.jsonnet. The regular workflowcommands like
tk apply,tk show, etc. will require the--nameflag if multiple environments are present.Ideally I'd like an interactive UI for selecting an environment, however there are multiple ways to do it with shell
integrations, for example
fzfhas been brought up in recent discussions. If we do want an integrated UI, I propose tointroduce that in a separate PR.
closes #432
be9dafc is a rebase of 91651e9 (kudos @sh0rez), which could also have its own PR, this PR just takes it one step further.
commit c15952a comes from #475, need a rebase after it is merged, compare without that commit