fix(tool/imports): add path info to error message #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
reviewed
Feb 22, 2021
sh0rez
changed the title
sh0rez
force-pushed
the
verbose-tool-imports
branch
from
b7207e0
to
adbebcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tk tool importsis a really useful tool for identify imports within a Jsonnet codebase.However, if you use it with a complex codebase, it can report "couldn't load foo/bar.libsonnet" without telling you where it was when it failed. This very minor tweak gives direct feedback as to where the error is facilitating an easy and immediate fix.