feat: support .metadata.generateName (#526) #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciechka
changed the title
Duologic
approved these changes
Mar 8, 2021
| @@ -62,7 +62,7 @@ func (m Manifest) Verify() error { | |||
| if !o.Get("metadata").IsMSI() { | |||
| fields["metadata"] = ErrInvalidMap | |||
| } | |||
| if !o.Get("metadata.name").IsStr() { | |||
| if !o.Get("metadata.name").IsStr() && !o.Get("metadata.generateName").IsStr() { | |||
There was a problem hiding this comment.
I don't know this code very well, not sure if we need to improve the error message too. @sh0rez
|
@Duologic Thanks for merging this. I was not sure how long I should wait and this was not urgent for me, so thank you for handling it. |
|
Yeah, I'm still not sure about the error message, but I think progress over perfection is fine here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
tk showandtk exportto handle K8s objects that use.metadata.generateNameinstead of.metadata.name.Changes the default format (being backwards compatible) to also support outputting such files with
tk export.