Add "validate" diff strategy #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this mode, diff will be called an additional time with "--server-side" The reason why it's called an additional time is because this argument will add server-only attributes to the diff such as "last-applied-configuration" By adding a second diff call that's only use to find errors, we keep the same diff as before but we add an extra validation Let me know if you think that this solution is adequate. I left the existing "native" mode as the default
Duologic
approved these changes
Apr 6, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
In the "validate" mode, diff will be called an additional time with "--server-side"
The reason why it's called an additional time is because this argument will add server-only attributes to the diff such as "last-applied-configuration", users probably don't want to see these since they will change on every run
By adding a second diff call that's only use to find errors, we keep the same diff as before but we add an extra validation
Let me know if you think that this solution is adequate. I left the existing "native" mode as the default
I also didn't add any tests, some guidance would be appreciated here. I might be mistaken but there doesn't seem to be any tests around Kubernetes.client.diff, is this because it meant to stay without any logic?