Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify --k8s=false for tk init #582

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

harmjanblok
Copy link
Contributor

Preserves compatibility with versions before 0.16.0.

#563 redefined flag as string, to optionally specify the desired k8s version. However only --k8s=true and --k8s=1.18 work but --k8s=false doesn't.

Preserves compatibility with versions before 0.16.0
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, took me a second to see the mistake I made.

@Duologic Duologic merged commit d265971 into grafana:main Jul 8, 2021
@harmjanblok harmjanblok deleted the init-with-k8s-false branch March 10, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants