Fix api-resources table parsing #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@simonswine. I think this could maybe cause issues with people running older kubectl versions. For example, |
For sometime `tk pruning` fails, as my cluster has overlapping CRD names. Errors persisted like this: ``` $ tk prune environments/default fetching UID's .. done 555.50452ms fetching previously created resources .. Error: error: the server doesn't have a resource type "NetworkAttachmentDefinition" ``` The reason why this was happing was a failed parsing of the `-o wide` table of `kubectl api-resources`: The field `APIGROUP` no longer exists and is now part of `APIVERSION`.
simonswine
force-pushed
the
20210821_fix-bug-api-resources-parsing
branch
from
3597a04
to
4cc9e29
Compare
|
@julienduchesne very good point. I have fixed this for both versions. I also noticed the test data was not fully accurate, so I replaced it with real one that I retrieved locally. |
simonswine
force-pushed
the
20210821_fix-bug-api-resources-parsing
branch
from
4cc9e29
to
0018b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sometime
tk pruningfails, as my cluster has overlapping CRD names/mismatching Kind and Name fields . Errors persisted like this:The reason why this was happing was a failed parsing of the
-o widetable ofkubectl api-resources: The fieldAPIGROUPno longer exists and is now part ofAPIVERSION.