tk/export: introduce a configurable memory ballast #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To signal that this is intended for experimental purposes.
julienduchesne
approved these changes
Feb 1, 2022
| vars := workflowFlags(cmd.Flags()) | ||
| getJsonnetOpts := jsonnetFlags(cmd.Flags()) | ||
| getLabelSelector := labelSelectorFlag(cmd.Flags()) | ||
|
|
||
| recursive := cmd.Flags().BoolP("recursive", "r", false, "Look recursively for Tanka environments") | ||
|
|
||
| cmd.Run = func(cmd *cli.Command, args []string) error { | ||
| // Allocate a block of memory to alter GC behaviour. See https://github.com/golang/go/issues/23044 |
There was a problem hiding this comment.
The issue doesn't seem to describe it as well as https://blog.twitch.tv/en/2019/04/10/go-memory-ballast-how-i-learnt-to-stop-worrying-and-love-the-heap/
Duologic
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: At GrafanaLabs, we are currently trying to optimise how long it takes us to do a
tk exportoperation of our jsonnet codebase.We are currently testing different alternatives, one of them is leveraging a memory ballast to reduce the amount of time spent doing garbage collection.
I'm currently working on getting some hard data to back that up, but in the meantime, I'm proposing this PR which introduces a memory ballast behind a hidden flag for
tk export.