Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backticks from -inject-labels flag desc #688

Merged

Conversation

colega
Copy link
Contributor

@colega colega commented Mar 31, 2022

Backticks in a flag description have a special meaning, in both standardflag and the pflag package used here.
Because of this, flag was described as:

--inject-labels tk prune       add tanka environment label to each created resource. Required for tk prune.

Now it will look like:

--inject-labels                add tanka environment label to each created resource. Required for 'tk prune'.

See spf13/pflag#200

Signed-off-by: Oleg Zaytsev mail@olegzaytsev.com

Backticks in a flag description have a special meaning, in both standard
`flag` and the `pflag` package used here. Because of this, flag was
described as:

    --inject-labels tk prune       add tanka environment label to each
                                   created resource. Required for tk prune.

Now it will look like:

    --inject-labels                add tanka environment label to each
                                   created resource. Required for 'tk prune'.

See spf13/pflag#200

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@julienduchesne
Copy link
Member

Thanks

@julienduchesne julienduchesne merged commit 56c2bd2 into main Mar 31, 2022
@julienduchesne julienduchesne deleted the remove-backticks-from-inject-labels-flag-description branch March 31, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants