Charts: Tighten validations #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #691 which is mostly a failure of error messages imo Instead of getting a `no such file`, the error is now: ``` $ tk tool charts add https://helm.releases.hashicorp.com/vault@0.19.0 Adding 1 Charts ... Skipping https://helm.releases.hashicorp.com/vault@0.19.0: not of form 'repo/chart@version(:path)' where repo contains no special characters. Error: 1 Chart(s) were skipped. Please check above logs for details ``` Also, adding an invalid repo now prints out a relevant error message instead of failing in helm commands ``` $ tk tool charts add-repo https://helm.releases.hashicorp.com https://helm.releases.hashicorp.com Skipping https://helm.releases.hashicorp.com: invalid name. cannot contain any special characters. Error: 1 Repo(s) were skipped. Please check above logs for details ```
Duologic
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #691 which is mostly a failure of error messages imo
Instead of getting a
no such file, the error is now:Also, adding an invalid repo now prints out a relevant error message instead of failing in helm commands