Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): environment manipulation #73

Merged
merged 3 commits into from
Sep 20, 2019
Merged

feat(cli): environment manipulation #73

merged 3 commits into from
Sep 20, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Sep 20, 2019

Adds a set of commands to work with and manipulate environments:

  • tk env add: Create a new environment, optionally setting parameters (now also used by tk init)
  • tk env remove (tk env rm): Remove an environment
  • tk env list (tk env ls): List environments (optionally as JSON)
  • tk env set: set properties on environments (the same available for tk env add)

These commands aim to be ks env compatible. However, Tanka infers the environments name from the directory, so it is not possible to modify it using add / set --name. Just mv the directory in that case (included in the error message).

Fixes #72

Adds a subcommand to list all available environments
@sh0rez sh0rez added kind/feature Something new should be added component/cli Command Line Interface labels Sep 20, 2019
@sh0rez sh0rez requested a review from rfratto September 20, 2019 18:18
@sh0rez sh0rez self-assigned this Sep 20, 2019
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sh0rez sh0rez merged commit d8092bd into master Sep 20, 2019
@sh0rez sh0rez deleted the env-cmds branch September 20, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cli Command Line Interface kind/feature Something new should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tk env commands
2 participants