getSnippetHash: Use regexp instead of parsing whole AST
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating the env hash to use as cache keys, we don't need an exact list of imports Therefore, to improve performance, we can replace the current strategy of using the AST by a regexp strategy. This new strategy can lead to false positives (e.g. a string containing import 'foo') but this is not an issue for the hashing function. All that matters is that the hash is consistent and accounts for all files (no false negatives)
|
Benchstat (compared to main): |
inkel
reviewed
Sep 16, 2022
Yeah, the issue with the AST is that you have to parse all of it and traverse all nodes |
julienduchesne
force-pushed
the
julienduchesne/get-snippet-hash
branch
from
d64804b
to
e999249
Compare
julienduchesne
added a commit
that referenced
this pull request
Sep 27, 2022
Made a stupid mistake in the previous PR: #759 This fixes it and adds another benchmark test to ensure it doesn't happen again. I also removed the Github Actions benchmark test, as it's not really useful, anytime we change the tests, we'll get erroneous results which will be annoying. Instead, I added the benchmark tests to the Drone run, we can compare whenever we want.
julienduchesne
added a commit
that referenced
this pull request
Sep 28, 2022
* Fix `getSnippetHash` not considering all files Made a stupid mistake in the previous PR: #759 This fixes it and adds another benchmark test to ensure it doesn't happen again. I also removed the Github Actions benchmark test, as it's not really useful, anytime we change the tests, we'll get erroneous results which will be annoying. Instead, I added the benchmark tests to the Drone run, we can compare whenever we want. * linting * Add changelog, will release straight away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the env hash to use as cache keys, we don't need an exact list of imports
Therefore, to improve performance, we can replace the current strategy of using the AST by a regexp strategy.
This new strategy can lead to false positives (e.g. a string containing import 'foo') but this is not an issue for the hashing function.
All that matters is that the hash is consistent and accounts for all files (no false negatives)
On actual huge real-life environments, I have seen improvements of up to 95% (from 2s to 100ms)