Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tanka 0.23.0 Changelog #764

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Tanka 0.23.0 Changelog #764

merged 1 commit into from
Sep 27, 2022

Conversation

julienduchesne
Copy link
Member

No description provided.

@github-actions
Copy link

Benchstat (compared to main):

name                                 old time/op    new time/op    delta
pkg:github.com/grafana/tanka/pkg/jsonnet goos:linux goarch:amd64
GetSnippetHash-2                       24.8ms ± 3%    25.3ms ± 6%   ~     (p=0.243 n=9+10)
pkg:github.com/grafana/tanka/pkg/tanka goos:linux goarch:amd64
ExportEnvironmentsWithReplaceEnvs-2    9.70ms ±10%    9.47ms ± 9%   ~     (p=0.393 n=10+10)

name                                 old alloc/op   new alloc/op   delta
pkg:github.com/grafana/tanka/pkg/jsonnet goos:linux goarch:amd64
GetSnippetHash-2                       3.86MB ± 0%    3.86MB ± 0%   ~     (p=0.529 n=10+10)
pkg:github.com/grafana/tanka/pkg/tanka goos:linux goarch:amd64
ExportEnvironmentsWithReplaceEnvs-2    2.04MB ± 0%    2.04MB ± 0%   ~     (p=0.720 n=9+10)

name                                 old allocs/op  new allocs/op  delta
pkg:github.com/grafana/tanka/pkg/jsonnet goos:linux goarch:amd64
GetSnippetHash-2                        32.3k ± 0%     32.3k ± 0%   ~     (p=0.645 n=10+9)
pkg:github.com/grafana/tanka/pkg/tanka goos:linux goarch:amd64
ExportEnvironmentsWithReplaceEnvs-2     23.5k ± 0%     23.5k ± 0%   ~     (p=0.706 n=10+9)

@julienduchesne julienduchesne requested a review from a team September 27, 2022 01:27
the-it
the-it approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@the-it the-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienduchesne julienduchesne merged commit 1bac47d into main Sep 27, 2022
@julienduchesne julienduchesne deleted the julienduchesne/tanka-0.23.0 branch September 27, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-it the-it the-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @the-it