Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add a "Grafana-Terraform-Provider-Version" header to requests #1694

Closed
joeblubaugh opened this issue Jul 17, 2024 · 1 comment · Fixed by #1700
Closed
Assignees

Comments

@joeblubaugh
Copy link
Contributor

Feature Request

The provider sets a header "Grafana-Terraform-Provider" to "true", similar to using a user agent, so that endpoints it calls can provide special treatment if necessary. It would be nice to know the version of the provider so backends can provide specific messaging based on version, including things like:

  • "version is not supported. upgrade to XYZ"
  • including or hiding fields or data that cause known breakages in the provider
  • structure translation in the API after a migration in the backend that changes structure.

I would suggest one of two approaches:

  • Add a new header that includes the version
  • Change the value set for "Grafana-Terraform-Provider" to the version of the provider.

Working with a blank slate, I would go for the second approach because it reduces the total number of headers, but if we stop using "true" it's possible that some backends depend on that exact value and would break. So I'd lean towards adding an additional header if this feature request is accepted.

@julienduchesne
Copy link
Member

Can't hurt to have this information: #1700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants