Merge CheckOSSTestsEnabled and CheckOSSTestsSemver helpers
#1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw the semver function being used in a cloud test, which is invalid This should prevent that happening
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
|
The cloud test in question is failing but I'll fix it in a future PR |
inkel
approved these changes
Oct 27, 2023
| t.Helper() | ||
|
|
||
| if len(semverConstraintOptional) > 1 { | ||
| panic("checkSemverConstraint accepts at most one argument") |
There was a problem hiding this comment.
Good call using a panic here! I was going to suggest t.Fatal instead, but then I realized it is not the test that fails but actually the test's definition, so this is definitely one of the right usages of panic 👏🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the semver function being used in a cloud test, which is invalid
This should prevent that happening