Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data sources: Add Admin permission to data source permission options #1133

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

IevaVasiljeva
Copy link
Contributor

What

Fixes https://github.com/grafana/identity-access-team/issues/453

@IevaVasiljeva IevaVasiljeva requested a review from a team as a code owner November 7, 2023 14:41
Copy link

github-actions bot commented Nov 7, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne
Copy link
Member

LGTM! Test doesn't run until we have 10.3 released (or have some way to test on the latest Grafana stable changeset) but I'm not going to let that block the PR

Copy link
Member

@aarongodin aarongodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@julienduchesne julienduchesne merged commit d5aed61 into master Nov 10, 2023
23 checks passed
@julienduchesne julienduchesne deleted the data-source-permissions branch November 10, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants