OpenAPI: Fix API calls pointing to subpath #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Closes #1137 Currently, the test suite is pointing to a subpath BUT Grafana redirects from the root to the subpath The provider is badly configured but the tests still pass because of the redirect To fix the test suite, I add a nginx proxy in this PR, so that calling the host directly fails and you have to go through the subpath I've also reworked the Makefile so that it has more common args (less repetition of configs), so it's harder to make a mistake
julienduchesne
force-pushed
the
julienduchesne/fix-subpath
branch
from
5eba6e5
to
201247c
Compare
julienduchesne
commented
Nov 9, 2023
| @@ -438,7 +442,7 @@ func createGrafanaOAPIClient(apiURL string, d *schema.ResourceData) (*goapi.Graf | |||
|
|
|||
| cfg := goapi.TransportConfig{ | |||
| Host: u.Host, | |||
| BasePath: "/api", | |||
| BasePath: apiPath, | |||
There was a problem hiding this comment.
The actual fix is here
K-Phoen
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1137
Currently, the test suite is pointing to a subpath BUT Grafana redirects from the root to the subpath
The provider is badly configured but the tests still pass because of the redirect
To fix the test suite, I add a nginx proxy in this PR, so that calling the host directly fails and you have to go through the subpath
I've also reworked the Makefile so that it has more common args (less repetition of configs), so it's harder to make a mistake