Permission Resources: Allow empty permissions #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #142 When programatically managing permissions, it can be useful to keep the permissions resource but remove all permissions Also, without this change, resources with no permissions cannot be imported because the permissions resources are invalid with an empty set of permissions Also updated the docs to make it clear that it manages the whole set of permissions.
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
inkel
approved these changes
Nov 22, 2023
julienduchesne
deleted the
julienduchesne/permission-resources-allow-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
When programatically managing permissions, it can be useful to keep the permissions resource but remove all permissions Also, without this change, resources with no permissions cannot be imported because the permissions resources are invalid with an empty set of permissions
Also updated the docs to make it clear that it manages the whole set of permissions.