Migrate Reports to OpenAPI #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
spinillos
commented
Dec 13, 2023
| uid := d.Get("dashboard_uid").(string) | ||
| if uid == "" { | ||
| // It triggers the old way to generate reports | ||
| report.DashboardID = id |
There was a problem hiding this comment.
We aren't able to retrieve dashboards by id anymore.
We need to set it in the deprecated dashboard_id to make it works.
| @@ -235,7 +235,8 @@ func deleteAlertRuleGroup(ctx context.Context, data *schema.ResourceData, meta i | |||
| group := resp.Payload | |||
|
|
|||
| for _, r := range group.Rules { | |||
| _, err := client.Provisioning.DeleteAlertRule(r.UID) | |||
| params := provisioning.DeleteAlertRuleParams{UID: r.UID} | |||
There was a problem hiding this comment.
If you rebase, you can get rid of this change and the go mod update!
There was a problem hiding this comment.
Yeah! I saw that in your PR 😂
spinillos
force-pushed
the
migrate-reports-oapi
branch
from
a75c8f2
to
abc2ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It migrates Reports to OpenAPI.
Depends of: grafana/grafana-openapi-client-go#49