Remove validation in new provider framework config #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validation was added here: #1206 However, it's done too early and it prevents the cases where we create a second provider with auth from a dynamically created API key or service account
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
inkel
approved these changes
Dec 15, 2023
julienduchesne
deleted the
julienduchesne/remove-new-provider-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validation was added here: #1206
However, it's done too early and it prevents the cases where we create a second provider with auth from a dynamically created API key or service account