Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add of disable_provenance for grafana_contact_point #1255

Merged
merged 2 commits into from
Jan 25, 2024
Merged

✨ Add of disable_provenance for grafana_contact_point #1255

merged 2 commits into from
Jan 25, 2024

Conversation

afreyermuth98
Copy link
Contributor

No description provided.

@afreyermuth98 afreyermuth98 requested a review from a team as a code owner December 27, 2023 16:17
@CLAassistant
Copy link

CLAassistant commented Dec 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne
Copy link
Member

Tests are failing with

Error: internal/resources/grafana/resource_alerting_contact_point_test.go:89:109: missing ',' before newline in argument list

@afreyermuth98
Copy link
Contributor Author

Updated 😬

@julienduchesne
Copy link
Member

Updated 😬

Sorry, I merged some PRs today so you'll have to update your branch to fix the conflicts

@julienduchesne
Copy link
Member

👋 Can you squash the commits. It's a bit hard to review as it is

@afreyermuth98
Copy link
Contributor Author

Done :)

@afreyermuth98 afreyermuth98 requested a review from a team as a code owner January 25, 2024 15:17
julienduchesne
julienduchesne approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienduchesne julienduchesne merged commit 66ef898 into grafana:master Jan 25, 2024
22 of 24 checks passed
@renovate renovate bot mentioned this pull request Oct 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienduchesne julienduchesne julienduchesne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afreyermuth98 @CLAassistant @julienduchesne