Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder permissions: use the new RBAC endpoints for folder permission resource #1293

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

IevaVasiljeva
Copy link
Contributor

@IevaVasiljeva IevaVasiljeva commented Jan 22, 2024

What

Change the code to use the new RBAC endpoints for updating the folder permissions instead of the old deprecated ACL endpoints. There should be no changes in the behaviour.

Related to https://github.com/grafana/identity-access-team/issues/424

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienduchesne
Copy link
Member

Failing test is just a flaky test. Merging!

@julienduchesne julienduchesne merged commit d1db83c into master Jan 22, 2024
23 of 24 checks passed
@julienduchesne julienduchesne deleted the ieva/use-new-rbac-endpoints-for-folder-perms branch January 22, 2024 12:16
afreyermuth98 pushed a commit to afreyermuth98/terraform-provider-grafana that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants