Ease of use: Add validation that org_id isn't used with API Keys/SA Tokens #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okens Closes #1157 A source of confusion that we get occasionally get questions about is when users try to create org resources with an API key API keys are org-scoped already and when they are used, the org header will be ignored by the API This means that the resources will still be created but not where the user expects This PR adds a validation on the Create function of every resource. If org_id is set and we're using an API key, then throw an error instead of the unexpected behavior
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
spinillos
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1157
A source of confusion that we get occasionally get questions about is when users try to create org resources with an API key
API keys are org-scoped already and when they are used, the org header will be ignored by the API
This means that the resources will still be created but not where the user expects
This PR adds a validation on the Create function of every resource. If org_id is set and we're using an API key, then throw an error instead of the unexpected behavior