Typed resource ID helper #1395
Merged
Typed resource ID helper #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
julienduchesne
force-pushed
the
julienduchesne/typed-resource-id
branch
from
2436395
to
2e5a47a
Compare
julienduchesne
commented
Mar 2, 2024
| @@ -87,24 +86,14 @@ func testAccGrafanaAuthCheckServiceAccounts(stack *gcom.FormattedApiInstance, ex | |||
| return fmt.Errorf("failed to get service accounts: %w", err) | |||
| } | |||
|
|
|||
| var foundSAs []string | |||
There was a problem hiding this comment.
This test is broken from a recent change to Grafana Cloud. Some service accounts are auto-provisioned into new stacks
julienduchesne
force-pushed
the
julienduchesne/cloud-private
branch
from
9b26801
to
b8b84d2
Compare
Each resource's ID is composed of n (>=1) string or integer elements We can generalize this behavior and do the parsing/formatting in the helper function This is extracted from #1391 and is part of a push to have standardized IDs for all resources, allowing for easier generation of TF code!
julienduchesne
force-pushed
the
julienduchesne/typed-resource-id
branch
from
2e5a47a
to
83eecfc
Compare
malcolmholmes
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each resource's ID is composed of n (>=1) string or integer elements
We can generalize this behavior and do the parsing/formatting in the helper function
This is extracted from #1391 and is part of a push to have standardized IDs for all resources, allowing for easier generation of TF code!