Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder datasource fixes #1416

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Folder datasource fixes #1416

merged 1 commit into from
Mar 13, 2024

Conversation

julienduchesne
Copy link
Member

  • Make the nested folders tests run in OSS, not in the cloud instance
  • Build the folder datasource from the folder resource's schema, rather than duplicating things
  • (bugfix) Use the search API rather than the get folders API, it seems that the latter does not return nested folders

@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne
Folder datasource fixes
eb83a13 
- Make the nested folders tests run in OSS, not in the cloud instance
- Build the folder datasource from the folder resource's schema, rather than duplicating things
- (bugfix) Use the search API rather than the get folders API, it seems that the latter does not return nested folders
@julienduchesne julienduchesne force-pushed the julienduchesne/fix-datasource-folder branch from f62460b to eb83a13 Compare March 13, 2024 15:02
@julienduchesne julienduchesne marked this pull request as ready for review March 13, 2024 15:07
@julienduchesne julienduchesne requested a review from a team as a code owner March 13, 2024 15:07
@julienduchesne julienduchesne merged commit e731c71 into main Mar 13, 2024
25 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/fix-datasource-folder branch March 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Phoen K-Phoen K-Phoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienduchesne @K-Phoen