Config Generation: Go implementation for executing Terraform binary #1592
Conversation
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
| @@ -125,3 +128,5 @@ require ( | |||
| gopkg.in/yaml.v2 v2.4.0 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/hashicorp/terraform-exec v0.21.0 => github.com/hrmsk66/terraform-exec v0.21.0 | |||
There was a problem hiding this comment.
Using a fork awaiting the merge of this PR: hashicorp/terraform-exec#446
| func setupTerraform(cfg *Config) (*tfexec.Terraform, error) { | ||
| installer := &releases.ExactVersion{ | ||
| Product: product.Terraform, | ||
| Version: version.Must(version.NewVersion("1.8.4")), |
There was a problem hiding this comment.
I've pinned the version here for now, should probably become configurable.
| state, err := runTerraformWithOutput(dir, "show", "-json") | ||
| func getState(ctx context.Context, cfg *Config) (*tfjson.State, error) { |
There was a problem hiding this comment.
tfexec implements tfjson to read the state, hence the big changeset in this file.
pkg/generate/generate.go
Outdated
| stack := stack{ | ||
| name: stackName, | ||
| managementKey: cfg.Grafana.Auth, | ||
| url: cfg.Grafana.URL, | ||
| smToken: "", | ||
| smURL: "", | ||
| } |
There was a problem hiding this comment.
Synthesizing a stack here to reduce the signatures of the generate functions.
| return fmt.Errorf("failed to run terraform init: %w", err) | ||
| } | ||
| cfg.Terraform = tf |
There was a problem hiding this comment.
Not sure if this is the best place to put it, probably not but, eh 🤷
Duologic
force-pushed
the
duologic/gonative_tfexec
branch
from
dbab7b6
to
ed45869
Compare
go.mod
Outdated
| @@ -33,6 +33,14 @@ require ( | |||
| golang.org/x/text v0.15.0 | |||
| ) | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
Merge this with the upper block IMO
There was a problem hiding this comment.
I've just used go mod edit -replace and go mod tidy, stupid tools doing stupid things :P
This PR refactors the generator to use https://github.com/hashicorp/terraform-exec/ to execute the Terraform binary. This removes the need for the user to provide the Terraform binary as part of their runtime environment, allowing the generator to be used as a library with less friction.