Config Generation: Redact credentials from generated config #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Creds are redacted by default, the behaviour can be changed through the `OutputCredentials` config Also reworked the postprocessor stuff a bit so that the file-writing logic isn't repeated a bunch of times (it's a no-op overall)
julienduchesne
force-pushed
the
julienduchesne/redact-credentials
branch
from
1cab4de
to
0bdc486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creds will now be redacted by default. The behaviour can be changed through the
OutputCredentialsconfigAlso, I've reworked the postprocessor stuff a bit so that the file-writing logic isn't repeated a bunch of times. I will rework it further once this is merged. I want post-processing to be its own package and each process an interface implementation