Check oncall rolling_users shift does not include empty group #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
matiasb
force-pushed
the
oncall-shift-empty-rolling-group
branch
2 times, most recently
from
9b81cda
to
1640076
Compare
| @@ -46,6 +46,13 @@ func TestAccOnCallOnCallShift_basic(t *testing.T) { | |||
| resource.TestCheckResourceAttr("grafana_oncall_on_call_shift.test-acc-on_call_shift", "frequency", "hourly"), | |||
| ), | |||
| }, | |||
| { | |||
| Config: testAccOnCallOnCallShiftEmptyRollingUsers(scheduleName, shiftName), | |||
There was a problem hiding this comment.
Could we also have another test that does test the new error message?
matiasb
force-pushed
the
oncall-shift-empty-rolling-group
branch
from
01b3960
to
ccce415
Compare
julienduchesne
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to grafana/oncall#4603