Config Generation: Add some missing listers #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
requested review from
peterschretlen and
The-9880
and removed request for
a team
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
- SA - Team - User - SM Checks
julienduchesne
force-pushed
the
julienduchesne/add-missing-listers
branch
from
9411bb1
to
edb3f2b
Compare
julienduchesne
force-pushed
the
julienduchesne/add-missing-listers
branch
from
4367683
to
9631419
Compare
peterschretlen
approved these changes
Jul 17, 2024
| // } | ||
| // return ids, nil | ||
| // } | ||
| func listChecks(ctx context.Context, client *common.Client, data any) ([]string, error) { |
There was a problem hiding this comment.
Out of curiosity, what was it that needed to be fixed - the lister code does not seem to have changed?
There was a problem hiding this comment.
I don't know. The generator has gone through lots of changes since this was commented out. It works now 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a tiny tool to list resources that don't have a lister