Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLO: Update openapi provider and support search_expression #1695

Merged
merged 5 commits into from
Jul 24, 2024
Merged

SLO: Update openapi provider and support search_expression #1695

merged 5 commits into from
Jul 24, 2024

Conversation

joeblubaugh
Copy link
Contributor

Updating the openapi provider adds support for the new read-only optional field "allowedActions" and the renamed "searchExpression" fields on SLOs.

This change also adds code to handle converting the search expression between HCL and JSON for the API

@joeblubaugh joeblubaugh requested review from a team as code owners July 17, 2024 07:52
@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

joeblubaugh and others added 3 commits July 19, 2024 13:23
@joeblubaugh @julienduchesne
SLO: Update openapi provider and support search_expression
a8c8b8f 
Updating the openapi provider adds support for the new read-only
optional field "allowedActions" and the renamed "searchExpression"
fields on SLOs.

This change also adds code to handle converting the search expression
between HCL and JSON for the API
@julienduchesne
Regenerate docs
c4a63cc
@julienduchesne
Fix generate docs check. It was out of date
0d24ef0
@julienduchesne
Undo docs thing
d5ad3db
@julienduchesne
Fix search_expression and tests
a09aa7c 
Doesn't seem to be returned by the API though
@julienduchesne
Copy link
Member

Hey @joeblubaugh, I tried fixing the tests but it looks like the search expression is not being persisted/returned (haven't investigated much). Is it possible our cloud instance doesn't have the feature yet? (tfprovidertests.grafana.net)

@cesararmada
Copy link

hey @julienduchesne We released the v1.22.1 version of the plugin yesterday to prod and it contains the searchExpression field in the responses. That should fix this issue, sorry for the delay.

@julienduchesne
Copy link
Member

hey @julienduchesne We released the v1.22.1 version of the plugin yesterday to prod and it contains the searchExpression field in the responses. That should fix this issue, sorry for the delay.

No worries! I was just wondering what was wrong. Thanks for the update 😄

@julienduchesne julienduchesne merged commit bc4f342 into main Jul 24, 2024
26 checks passed
@julienduchesne julienduchesne deleted the joeb/add-slo-search-expression branch July 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesararmada cesararmada cesararmada approved these changes

@julienduchesne julienduchesne Awaiting requested review from julienduchesne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeblubaugh @julienduchesne @cesararmada