Config Generation: Generate resources with sensitive attributes #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fairly complex one but it's the last missing piece to full config generation The `terraform plan -generate-config-out` command is overly aggressive in redacting sensitive values Whenever a child attribute of a block is sensitive, the whole block is redacted, meaning that the generated resources are invalid if the block was required In this PR: - Add listers for `grafana_user` and `grafana_contact_point` - Replace nulled sensitive attributes with a placeholder (example: `password` in `grafana_user`_) - Generate "sensitive" blocks by making all attribute non-sensitive. This is a bit hacky but it's integrated well enough and I haven't found a better way (tried lots of things)
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly complex one but it's the last missing piece to full config generation
The
terraform plan -generate-config-outcommand is overly aggressive in redacting sensitive valuesWhenever a child attribute of a block is sensitive, the whole block is redacted, meaning that the generated resources are invalid if the block was required
In this PR:
grafana_userandgrafana_contact_pointpasswordingrafana_user_)