Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO: Fix validation for SAML certificate and private key #1721

Merged
merged 1 commit into from
Jul 26, 2024
Merged

SSO: Fix validation for SAML certificate and private key #1721

merged 1 commit into from
Jul 26, 2024

Conversation

dmihai
Copy link
Contributor

@dmihai dmihai commented Jul 26, 2024

SAML validations for the certificate and private key are fixed in this PR. The correct rules are:

  • Certificate and private key are either both configured or none of them is configured.
  • Cannot mix value and path when configuring the certificate and private key. If they are configured then they both have to use either the value or file paths.

@dmihai dmihai requested a review from a team as a code owner July 26, 2024 14:10
@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne merged commit 4bc50ca into main Jul 26, 2024
26 checks passed
@julienduchesne julienduchesne deleted the dmihai/saml-cert-validation branch July 26, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienduchesne julienduchesne julienduchesne approved these changes

@linoman linoman Awaiting requested review from linoman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihai @julienduchesne