Cloud: Fix stack wake-up function #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Closes #1725 In #1545, the stack readiness check was improved by calling the `/api/health` endpoint instead of just the stack URL While this does provide a better indication that the instance is up and running, the `/api/health` subpath does not trigger Grafana Cloud's stack wake-up With this PR, we'll call both the stack's base URL and its health endpoint
julienduchesne
force-pushed
the
julienduchesne/wake-up-properly
branch
from
222c3f3
to
8e9661e
Compare
spinillos
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1725
In #1545, the stack readiness check was improved by calling the
/api/healthendpoint instead of just the stack URL. While this does provide a better indication that the instance is up and running, the/api/healthsubpath does not trigger Grafana Cloud's stack wake-upWith this PR, we'll call both the stack's base URL and its health endpoint