Config Generation: Fix oncall #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
malcolmholmes
approved these changes
Aug 2, 2024
julienduchesne
force-pushed
the
julienduchesne/sm-check-generate-tes
branch
from
a30cca8
to
e65c9eb
Compare
Currently, we have errors with two oncall resources: - Schedule: `web` type schedules are fetched but they can't be managed with TF - Escalation: Mutually exclusive attributes are being set. With this change, all `nil` attributes won't be set in the TF state (rather than a zero value)
julienduchesne
force-pushed
the
julienduchesne/fix-oncall-generation
branch
from
b7983e0
to
b4fa5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have errors with two oncall resources:
webtype schedules are fetched but they can't be managed with TFnilattributes won't be set in the TF state (rather than a zero value)