Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Generation: Omit org ID from Grafana resources #1762

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

julienduchesne
Copy link
Member

(If there's only one org being generated)
If all resources are in the default org, there's no reason to have the 1: prefix to all resources
This makes resource names and IDs much nicer to look at

@julienduchesne julienduchesne requested a review from a team as a code owner August 9, 2024 02:31
Copy link

github-actions bot commented Aug 9, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne force-pushed the julienduchesne/omit-org-id branch 2 times, most recently from 502259e to be8d719 Compare August 9, 2024 12:33
(If there's only one org being generated)
If all resources are in the default org, there's no reason to have the `1:` prefix to all resources
This makes resource names and IDs much nicer to look at
@julienduchesne julienduchesne merged commit ca1501e into main Aug 9, 2024
26 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/omit-org-id branch August 9, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants