Provider: MaxConnsPerHost tests with creating 60 service accounts #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
eleijonmarck
requested review from
hairyhenderson,
julienduchesne and
IevaVasiljeva
eleijonmarck
commented
Mar 8, 2023
internal/provider/provider.go
Outdated
| @@ -340,6 +340,7 @@ func createGrafanaClient(d *schema.ResourceData) (string, *gapi.Config, *gapi.Cl | |||
| auth := strings.SplitN(d.Get("auth").(string), ":", 2) | |||
| cli := cleanhttp.DefaultClient() | |||
| transport := cleanhttp.DefaultTransport() | |||
| transport.MaxConnsPerHost = 2 | |||
There was a problem hiding this comment.
limiting the amount of concurrent HTTP connections from the provider makes it not overload the API and DB
There was a problem hiding this comment.
Can you make that a comment in the code?
julienduchesne
approved these changes
Mar 8, 2023
internal/provider/provider.go
Outdated
| @@ -340,6 +340,7 @@ func createGrafanaClient(d *schema.ResourceData) (string, *gapi.Config, *gapi.Cl | |||
| auth := strings.SplitN(d.Get("auth").(string), ":", 2) | |||
| cli := cleanhttp.DefaultClient() | |||
| transport := cleanhttp.DefaultTransport() | |||
| transport.MaxConnsPerHost = 2 | |||
There was a problem hiding this comment.
Can you make that a comment in the code?
IevaVasiljeva
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why/what
We have seen that too many simultaneous calls to grafana API can cause the DB to be congested.
Features
downside
might slow down terraform providers for our users
fixes
#827