Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook message and title fields #875

Merged

Conversation

skatsaounis
Copy link
Contributor

Fixes #817

@skatsaounis skatsaounis requested a review from a team as a code owner April 11, 2023 06:08
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

@skatsaounis
Copy link
Contributor Author

Tests are passing with Grafana OSS 9.3.11 inside a Docker container:

docker run --rm -p 3000:3000 grafana/grafana:9.3.11
GRAFANA_URL=http://localhost:3000 \
GRAFANA_AUTH=admin:admin \
GRAFANA_ORG_ID=1 \
TF_ACC_OSS=true \
TF_ACC=1 \
GRAFANA_VERSION="9.3.11" \
go test ./internal/resources/grafana/resource_alerting_contact_point_test.go -v
=== RUN   TestAccContactPoint_basic
=== PAUSE TestAccContactPoint_basic
=== RUN   TestAccContactPoint_compound
--- PASS: TestAccContactPoint_compound (2.64s)
=== RUN   TestAccContactPoint_notifiers
=== PAUSE TestAccContactPoint_notifiers
=== CONT  TestAccContactPoint_basic
=== CONT  TestAccContactPoint_notifiers
--- PASS: TestAccContactPoint_basic (1.87s)
--- PASS: TestAccContactPoint_notifiers (2.94s)
PASS
ok  	command-line-arguments	5.898s

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @alexweav would you like to take a look?

@julienduchesne julienduchesne merged commit 9a5e14b into grafana:master Apr 12, 2023
Copy link
Contributor

@alexweav alexweav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contact_point/webhook: support setting title and message for grafana 9.3
5 participants