Alerting: Fix grafana_contact_point ignores changes in secure fields #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we suppressed the comparison of secure fields and stored "[REDACTED]" in state. This change will instead store the unredacted values in state on create/update and patch them during read. This way, Terraform can identify and update changed secure field values.
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
|
Weird, I see tests failing with REDACTED values being seen, but I don't see anymore references about that string anymore in the code 🤔 Does the API return |
|
Yes, the API returns |
julienduchesne
approved these changes
Apr 13, 2023
armandgrillet
deleted the
jacobsonmt/fix_grafana_contact_point_secure_fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we suppressed the comparison of secure fields and stored "[REDACTED]" in state. This change will instead store the unredacted values in state on create/update and patch them during read.
This way, Terraform can identify and update changed secure field values.
Fixes: #713