Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Support folder UID as reference #900

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Apr 27, 2023

Currently, the dashboard resource only supports numeric folder IDs
However, in a context where someone is managing the dashboard but not the folder, it's much easier to use a UID

Also, IDs are being deprecated in favor of UIDs in the future

In this PR, I add UID support to the folder field. Numeric ID support remains the same

@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

Currently, the dashboard resource only supports numeric folder IDs
However, in a context where someone is managing the dashboard but not the folder, it's much easier to use a UID

In this PR, I add UID support to the `folder` field. Numeric ID support remains the same
@julienduchesne julienduchesne force-pushed the julienduchesne/folder-support-uid branch from 36a2cd4 to 4eaa5db Compare April 27, 2023 13:31
@julienduchesne julienduchesne marked this pull request as ready for review April 27, 2023 13:42
@julienduchesne julienduchesne requested a review from a team as a code owner April 27, 2023 13:42
@julienduchesne julienduchesne merged commit 2e11cc0 into master Apr 27, 2023
@julienduchesne julienduchesne deleted the julienduchesne/folder-support-uid branch April 27, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants