Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add details field to pagerduty contact point #912

Merged
merged 2 commits into from
May 11, 2023

Conversation

alexweav
Copy link
Contributor

@alexweav alexweav commented May 5, 2023

Grafana recently added a new details field to pagerduty in https://github.com/grafana/alerting/pull/65/files

Add it to the provider.

@github-actions
Copy link

github-actions bot commented May 5, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschaeffer
Copy link

Thank y'all for jumping on this!

@bschaeffer
Copy link

Probably closes #911 when merged

@bschaeffer
Copy link

bschaeffer commented May 9, 2023

What are the odds this gets merged and officially release in the next week? Just wondering what the process is after merge so we can plan some work related.

@alexweav alexweav merged commit 1ed77f5 into master May 11, 2023
@alexweav alexweav deleted the alexweav/pagerduty-details branch May 11, 2023 17:38
@bschaeffer
Copy link

🎉 Thank y'all for getting this out so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants