Adds a Global Header to all Grafana Terraform Provider requests #913
Conversation
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
| func getHTTPHeadersMap(d *schema.ResourceData) (map[string]string, error) { | ||
| headers := map[string]string{"Grafana-Terraform-Provider": "true"} |
There was a problem hiding this comment.
Sorry to ask after this is already merged, but:
What do you think about making this header more flexible? Maybe something like "Grafana-Request-Origion": "terraform"? That lets us provide options for other tooling in the future - we could propose adding headers to grabana and also to tools Grafana provides.
I've raised an issue on grafana/grafana
There was a problem hiding this comment.
Open to renaming this key-value pair to something more suitable - let's see if anybody has more thoughts on the discussion within grafana/grafana that you've linked out below, and I'm open to modifying this.
Proposal to add a Global HTTP Custom Header to all requests coming from the Grafana Terraform Provider.
This PR would add the custom HTTP header:
"Grafana-Terraform-Provider" : "true"to all requests originating from the Terraform Provider, in addition to any other
http_headersor customGRAFANA_HTTP_HEADERSenvironment variables that are set by the user.