Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support literal certificates #929

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

julienduchesne
Copy link
Member

Closes #273

10 minutes fix. Clearing out the clutter in the issues list :)

Closes #273

10 minutes fix. Clearing out the clutter in the issues list :)
@julienduchesne julienduchesne requested a review from a team as a code owner June 2, 2023 17:43
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

@julienduchesne julienduchesne merged commit 8ecd918 into master Jun 2, 2023
@julienduchesne julienduchesne deleted the julienduchesne/literal-certs branch June 2, 2023 17:55
@lornest
Copy link
Contributor

lornest commented Jul 24, 2024

Hey @julienduchesne - one from the archives for you! Sorry 😅 . When I try this change passing in ca_cert as a literal, I get:

│   failed to create clients
│   with provider["registry.terraform.io/grafana/grafana"],
│   on main.tf line 10, in provider "grafana":
│   10: provider "grafana" {
│ open     -----BEGIN CERTIFICATE-----
| CERT BODY HERE
| -----END CERTIFICATE-----
│ : file name too long

Just wondering if I'm missing something with this change and how I'm passing the literal value for the cert? Passing like:

provider "grafana" {
  url     = "<url>"
  auth    = "<token>"
  ca_cert = <<EOS
    -----BEGIN CERTIFICATE-----
  CERT BODY HERE
    -----END CERTIFICATE-----
EOS
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure provider using inline TLS instead of file path
3 participants