Fix potential panic on dashboards #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
inkel
reviewed
Jun 6, 2023
| @@ -362,7 +362,7 @@ func NormalizeDashboardConfigJSON(config interface{}) string { | |||
| // from the dashboard JSON other than "name" or "uid". | |||
| // Grafana will populate all other libraryPanel attributes, so delete them to avoid diff. | |||
| panels, hasPanels := dashboardJSON["panels"] | |||
| if hasPanels { | |||
| if hasPanels && panels != nil { | |||
There was a problem hiding this comment.
The error message is:
panic: interface conversion: interface {} is nil, not []interface {}
Wouldn't perhaps the right check be?
Suggested change
| if hasPanels && panels != nil { | |
| if _, ok := pabels.([]interface{}); ok && hasPanels { |
There was a problem hiding this comment.
hasPanels is useless in that case. I think we only need the cast in fact: https://go.dev/play/p/qCqc3sQfkNk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #921