Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chain/ethereum: RuntimeAdapter lazy EthAdapter #4508

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chain/ethereum: RuntimeAdapter lazy EthAdapter #4508

merged 1 commit into from
Mar 30, 2023

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Mar 30, 2023 •
edited
Loading

Fixes #4304

@mangas mangas requested review from leoyvens and neysofu March 30, 2023 12:23
@neysofu neysofu marked this pull request as ready for review March 30, 2023 12:52
neysofu
neysofu requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead on making the truple Optional, which is a bit of a long type, I think it would be better to have an fn insert_empty(&mut self, name: String) or fn insert_noop(&mut self, name: String). I'll leave the exact naming choice to you as you see fit.

@mangas mangas force-pushed the filipe/runtime-lazy-adapter branch from 3222873 to 2800672 Compare March 30, 2023 15:50
@mangas mangas requested a review from neysofu March 30, 2023 15:52
@mangas mangas merged commit 5fa50f9 into master Mar 30, 2023
@mangas mangas deleted the filipe/runtime-lazy-adapter branch March 30, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neysofu neysofu neysofu approved these changes

@leoyvens leoyvens Awaiting requested review from leoyvens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firehose only provider should be possible for Ethereum
2 participants
@mangas @neysofu