Source Schema Chapter #30
Open
+318
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
approved these changes
Apr 11, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
dariuszkuc
reviewed
Apr 12, 2024
benjie
reviewed
May 23, 2024
glen-84
suggested changes
Jun 15, 2024
glen-84
suggested changes
Jul 25, 2024
dariuszkuc
reviewed
Jul 30, 2024
dariuszkuc
reviewed
Jul 30, 2024
|
|
||
| ```graphql counter-example | ||
| type Query { | ||
| product(id: ID!, categoryId: Int): Product @lookup |
There was a problem hiding this comment.
as discussed during last meeting I believe this is actually valid?
There was a problem hiding this comment.
Yes ... I am gonna rewrite this part.
dariuszkuc
reviewed
Jul 30, 2024
| ``` | ||
|
|
||
| Nested lookups must imediately follow the parent lookup and cannot be nested | ||
| with fields inbetween. |
There was a problem hiding this comment.
I believe we agreed that inbetween fields are allowed only if they don't have any arguments
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Glen <glen.84@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
@entityReslolverto@lookupand introduces the agreed characteristics to the specification.TODOs: