[vite] set build.minify: false for cjs/esm builds (#3656)

* aa * Update .changeset/tidy-fans-reflect.md
graphql · Jul 25, 2024 · 93c7e9f · 93c7e9f
1 parent 82f1ecc
commit 93c7e9f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/tidy-fans-reflect.md b/.changeset/tidy-fans-reflect.md
@@ -0,0 +1,7 @@
+---
+"@graphiql/plugin-code-exporter": patch
+"@graphiql/plugin-explorer": patch
+"@graphiql/react": patch
+---
+
+set `build.minify: false` for cjs/esm builds since minified variable names change every build time
diff --git a/packages/graphiql-plugin-code-exporter/vite.config.ts b/packages/graphiql-plugin-code-exporter/vite.config.ts
@@ -7,6 +7,7 @@ const IS_UMD = process.env.UMD === 'true';
 export default defineConfig({
   plugins: [react({ jsxRuntime: 'classic' })],
   build: {
+    minify: IS_UMD ? 'esbuild' : false,
     // avoid clean cjs/es builds
     emptyOutDir: !IS_UMD,
     lib: {

diff --git a/packages/graphiql-plugin-explorer/vite.config.ts b/packages/graphiql-plugin-explorer/vite.config.ts
@@ -16,6 +16,7 @@ export default defineConfig({
     }),
   ],
   build: {
+    minify: IS_UMD ? 'esbuild' : false,
     // avoid clean cjs/es builds
     emptyOutDir: !IS_UMD,
     lib: {

diff --git a/packages/graphiql-react/vite.config.ts b/packages/graphiql-react/vite.config.ts
@@ -19,12 +19,8 @@ export default defineConfig({
       plugins: [postCssNestingPlugin()],
     },
   },
-  esbuild: {
-    // We use function names for generating readable error messages, so we want
-    // them to be preserved when building and minifying.
-    keepNames: true,
-  },
   build: {
+    minify: false,
     sourcemap: true,
     lib: {
       entry: 'src/index.ts',