Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce new IncrementalPublisher class #3894

Merged
merged 3 commits into from
Jun 17, 2023
Merged

Commits on Jun 10, 2023

  1. introduce new IncrementalPublisher

    = iterate only through completed items
    = remove extra ticks by making the publisher manage changes to its state synchronously.
    = use children array instead of promises to manage hierarchy
    = have IncrementalPublisher instantiate new IncrementalDataRecords
    
    = The new publisher sometimes cause an empty `{ hasNext: false }` to be emitted. In particular, because the publisher is faster than it was, it may emit a stream result before the stream's asynchronous iterator has completed.
    = The new publisher may sometimes reduce the number of `{ hasNext: false }` records that are emitted. For example, when errors on the initial result filter all subsequent results, this now happens synchronously, and so the publisher knows immediately that there are no subsequent results, such that there is no need for an empty final payload.
    yaacovCR committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    3e56887 View commit details
    Browse the repository at this point in the history
  2. add private modifier

    = requires reordering of methods because of eslint rule `@typescript-eslint/member-ordering`
    = adds underscore to private `_initialResult` property for consistency
    yaacovCR committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    a27ea60 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. typos

    yaacovCR committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    177cf6f View commit details
    Browse the repository at this point in the history