-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom speakers, individual speaker, and schedule pages for conf #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ graphql.github.io-source deploy preview ready
|
YassinEldeeb
force-pushed
the
custom-speakers-page
branch
from
July 21, 2023 20:38
60a8453
to
81368de
Compare
Thanks for doing this, Yassin, the improved experience will be appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds custom pages for:
/conf/schedule
shows the schedule of the conference/conf/speakers
shows a list of all of the speakers/conf/speakers/${username}
shows the individual speaker's info and his/her talks/conf/schedule/${id}
shows a schedule event's details.But why?
In the currently deployed version, we're embedding an iframe of the https://graphqlconf23.sched.com/ page, this introduced quite a few issues:
This hack of loading an iframe saved up a LOT of work, and the other approach of using Sched’s API took more work (but not too much) to design the components but solves all of the above issues.
This PR uses Sched's API and implements the individual pages related to the GraphQL Conference 2023 and statically builds them and serves them instantly because they're built beforehand. We've full control over the designs, and now we can share links on social media about the individual pieces of the conference (a specific speaker's page, speakers page, and schedule page)
For Gatsby to be able to use Sched's API to build those pages statically, we need to prove this env var by setting it in Gatsby Cloud Environment Variables