Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codegen blog post #1778

Merged
merged 13 commits into from
Sep 20, 2024
Merged

Add Codegen blog post #1778

merged 13 commits into from
Sep 20, 2024

Conversation

martinbonnin
Copy link
Contributor

Follow up from #1760

Copy link

vercel bot commented Sep 18, 2024

@martinbonnin is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.


All of that without having to write and maintain types manually!

For simplicity, this post uses TypeScript for code blocks but the same concepts can be applied to Swift/Kotlin.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reading this, feels like this could be an admonition at the end of the paragraph. Is there anything like this on the blog? Similar to GitHub note?

> [!NOTE]  
> For simplicity, this post uses TypeScript for code blocks but the same concepts can be applied to Swift/Kotlin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. @dimaMachina?

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar and consistency fixes; thanks @martinbonnin! 🙌

src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved

All of that without having to write and maintain types manually!

For simplicity, this post uses TypeScript for code blocks but the same concepts can be applied to Swift/Kotlin.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. @dimaMachina?

src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
src/pages/blog/2024-09-18-codegen.mdx Outdated Show resolved Hide resolved
martinbonnin and others added 9 commits September 18, 2024 14:03
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
@benjie
Copy link
Member

benjie commented Sep 18, 2024

@martinbonnin In case you're not aware; if you go to the "Files changed" tab, you can add suggestions to a batch and then commit them all at once.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jorydotcom another blog post ready to go, I think!

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 5:31pm

@martinbonnin
Copy link
Contributor Author

In case you're not aware; if you go to the "Files changed" tab, you can add suggestions to a batch and then commit them all at once.

Ah! I knew there was something! Apologies for the notification flood!

@michaelstaib
Copy link
Member

Looks good to me 🚀

@benjie benjie merged commit 67c5121 into graphql:source Sep 20, 2024
3 checks passed
@martinbonnin
Copy link
Contributor Author

Thanks all for the help and reviews ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants