Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-conf changes #1783

Merged
merged 7 commits into from
Oct 7, 2024
Merged

post-conf changes #1783

merged 7 commits into from
Oct 7, 2024

Conversation

YassinEldeeb
Copy link
Contributor

@YassinEldeeb YassinEldeeb commented Sep 23, 2024 •
edited by benjie
Loading

GraphQLConf 2024 Post-Event Website Transition

Sessions Updates

  • Link videos for each talk and workshop

Hero page Updates

  • Remove Call to Action buttons:
    • Get Your Ticket
    • Join as a Sponsor
    • Join as a Partner
  • Put up Post Event Message:
    • Thank you for Attending!
    • Message: "Thank you to all who joined us for GraphQLConf 2024! We look forward to seeing you at future events. To experience the best of this year's event, be sure to watch session recordings and slides from speakers, available on the event schedule for each talk."
    • Add button: “Explore all recordings and slides”
  • Add Flickr album link: Featured Photos
  • Hide Register button on top navigation bar
  • Hide Partner button on top navigation bar
  • Hide Pricing & Registration section (including Register Now button)
  • Hide What’s Included section
  • Hide Location & Venue section (including transportation, airport, parking info)
  • Update conference banner to invite people to watch the talks

FAQ Updates

  • Hide Emergency Resources section
  • Hide Onsite Resources section
  • Hide Visa Letter Request section

Fixes #1785

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024

@YassinEldeeb is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:28pm

@jorydotcom jorydotcom mentioned this pull request Sep 27, 2024
Closed
@jorydotcom
Copy link
Contributor

🎉 @benjie - Yassin's done it!

benjie
benjie requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing; thanks for your work on this! Just a couple things before we can ship it 🙌

vercel.json
Comment on lines +8 to +17
{
"source": "/conf/gallery",
"destination": "https://www.flickr.com/photos/linuxfoundation/albums/72177720320386221/",
"permanent": true
},
{
"source": "/conf/gallery/",
"destination": "https://www.flickr.com/photos/linuxfoundation/albums/72177720320386221/",
"permanent": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be /conf/2024/gallery instead?

Copy link
Contributor Author

@YassinEldeeb YassinEldeeb Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 2 galleries at the moment, one for 2023, and another for 2024, the default should always redirect to the latest conf, in that case 2024, so I think we should leave it as is /conf/gallery.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/conf/gallery is 404'ing in the deploy preview, will the redirects work after deploy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default should always redirect to the latest conf, in that case 2024, so I think we should leave it as is /conf/gallery.

Makes sense; but we should have a permalink of /conf/2024/gallery too IMO; at the moment we have:

https://graphql-github-io-git-fork-yassi-fb0c5c-the-graph-ql-foundation.vercel.app/conf/2024/gallery/ - 404

https://graphql-github-io-git-fork-yassi-fb0c5c-the-graph-ql-foundation.vercel.app/conf/gallery/ - redirects to Flickr 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/conf/gallery is 404'ing in the deploy preview, will the redirects work after deploy?

oh I'll fix it, it does seem to be broken indeed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; but we should have a permalink of /conf/2024/gallery too IMO

yeah, agree! I'll add it

src/app/conf/2024/_videos.ts Outdated Show resolved Hide resolved
@jemgillam
Copy link
Contributor

I've opened a PR at YassinEldeeb#3 for the updated video IDs

@jorydotcom jorydotcom mentioned this pull request Oct 7, 2024
Merged
3 tasks
benjie
benjie approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gallery link is still broken, but I don't know if that magically fixes itself on deploy. I'll go ahead and ship this, we can fix the gallery link in a follow-up PR.

@benjie benjie merged commit 3e65144 into graphql:source Oct 7, 2024
4 checks passed
@benjie
Copy link
Member

benjie commented Oct 7, 2024

Thanks for all your hard work on this @YassinEldeeb - excited to get this out there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorydotcom jorydotcom jorydotcom left review comments

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 2024 Conference Videos and Flickr photos to Conf. website
4 participants
@YassinEldeeb @jorydotcom @jemgillam @benjie